Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: components/proximity_auth/unlock_manager_impl.cc

Issue 2973243002: Adding pref to store the user-selected proximity threshold. (Closed)
Patch Set: Fixing tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/proximity_auth/unlock_manager_impl.cc
diff --git a/components/proximity_auth/unlock_manager_impl.cc b/components/proximity_auth/unlock_manager_impl.cc
index 92afbacee4338f8f51a3897338f6f18cf1d18196..855347896c830e131863023607072f2c7ecc4bbf 100644
--- a/components/proximity_auth/unlock_manager_impl.cc
+++ b/components/proximity_auth/unlock_manager_impl.cc
@@ -18,6 +18,7 @@
#include "components/proximity_auth/messenger.h"
#include "components/proximity_auth/metrics.h"
#include "components/proximity_auth/proximity_auth_client.h"
+#include "components/proximity_auth/proximity_auth_pref_manager.h"
#include "components/proximity_auth/proximity_monitor_impl.h"
#include "device/bluetooth/bluetooth_adapter_factory.h"
@@ -80,6 +81,8 @@ metrics::RemoteSecuritySettingsState GetRemoteSecuritySettingsState(
} // namespace
+class ProximityAuthPrefManager;
+
UnlockManagerImpl::UnlockManagerImpl(
ProximityAuthSystem::ScreenlockType screenlock_type,
ProximityAuthClient* proximity_auth_client)
@@ -158,7 +161,8 @@ void UnlockManagerImpl::OnLifeCycleStateChanged() {
if (state == RemoteDeviceLifeCycle::State::SECURE_CHANNEL_ESTABLISHED) {
DCHECK(life_cycle_->GetConnection());
DCHECK(GetMessenger());
- proximity_monitor_ = CreateProximityMonitor(life_cycle_->GetConnection());
+ proximity_monitor_ = CreateProximityMonitor(
+ life_cycle_->GetConnection(), proximity_auth_client_->GetPrefService());
GetMessenger()->AddObserver(this);
}
@@ -326,9 +330,11 @@ void UnlockManagerImpl::OnAuthAttempted(mojom::AuthType auth_type) {
}
std::unique_ptr<ProximityMonitor> UnlockManagerImpl::CreateProximityMonitor(
- cryptauth::Connection* connection) {
+ cryptauth::Connection* connection,
+ PrefService* pref_service) {
return base::MakeUnique<ProximityMonitorImpl>(
- connection, base::WrapUnique(new base::DefaultTickClock()));
+ connection, base::WrapUnique(new base::DefaultTickClock()),
+ base::MakeUnique<ProximityAuthPrefManager>(pref_service));
}
void UnlockManagerImpl::SendSignInChallenge() {

Powered by Google App Engine
This is Rietveld 408576698