Adding pref to store the user-selected proximity threshold.

chrome/browser/signin/easy_unlock_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/easy_unlock_service.h"
 
 #include <utility>
 
 #include "apps/app_lifetime_monitor.h"
 #include "apps/app_lifetime_monitor_factory.h"
@@ skipping 245 matching lines @@
 void EasyUnlockService::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterBooleanPref(prefs::kEasyUnlockAllowed, true);
   registry->RegisterBooleanPref(prefs::kEasyUnlockEnabled, false);
   registry->RegisterDictionaryPref(prefs::kEasyUnlockPairing,
                                    base::MakeUnique<base::DictionaryValue>());
   registry->RegisterBooleanPref(
       prefs::kEasyUnlockProximityRequired,
       false,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
+  registry->RegisterIntegerPref(

[Tim Song, 2017/07/07 21:48:24]

Note: We also need to sync this to the local state in
EasyUnlockServiceRegular::SyncProfilePrefsToLocalState().

[Tim Song, 2017/07/07 21:48:24]

Although there are a lot of prefs here, I want to gradually move all of them to
ProximityAuthPrefManager. There's also a lot of prefs here that are only used by
the Chrome app.

Can you make a RegisterProfilePrefs() function in ProximityAuthPrefManager
instead?

[sacomoto, 2017/07/10 16:54:07]

I moved it to ProximityAuthPrefManager. There is already a
ProximityAuthPrefManager::RegisterPrefs(), which we are calling below.

However, I kept the definition of prefs::kEasyUnlockProximityThreshold in the
chrome/common/pref_names.h, because I need to whitelist them here:
webui/settings/md_settings_localized_strings_provider.cc.

[sacomoto, 2017/07/10 16:54:07]

Done.

+      prefs::kEasyUnlockProximityThreshold, 1,
+      user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 
   if (base::CommandLine::ForCurrentProcess()->HasSwitch(
           proximity_auth::switches::kEnableBluetoothLowEnergyDiscovery))
     proximity_auth::ProximityAuthPrefManager::RegisterPrefs(registry);
 }
 
 // static
 void EasyUnlockService::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterStringPref(prefs::kEasyUnlockDeviceId, std::string());
   registry->RegisterDictionaryPref(prefs::kEasyUnlockHardlockState);
@@ skipping 637 matching lines @@
 
   // TODO(tbarzic): Set check_private_key only if previous sign-in attempt
   // failed.
   EasyUnlockTpmKeyManagerFactory::GetInstance()->Get(profile_)
       ->PrepareTpmKey(true /* check_private_key */,
                       base::Closure());
 #endif  // defined(OS_CHROMEOS)
 
   tpm_key_checked_ = true;
 }