Adding pref to store the user-selected proximity threshold.

components/proximity_auth/proximity_auth_pref_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/proximity_auth/proximity_auth_pref_manager.h"
 
 #include <memory>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/values.h"
+#include "chrome/common/pref_names.h"

[Tim Song, 2017/07/11 23:45:57]

We shouldn't depend on anything from chrome/.

[sacomoto, 2017/07/12 15:52:52]

Done.

+#include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 #include "components/prefs/scoped_user_pref_update.h"
 #include "components/proximity_auth/logging/logging.h"
 #include "components/proximity_auth/proximity_auth_pref_names.h"
 
 namespace proximity_auth {
 
 ProximityAuthPrefManager::ProximityAuthPrefManager(PrefService* pref_service)
     : pref_service_(pref_service) {}
 
 ProximityAuthPrefManager::~ProximityAuthPrefManager() {}
 
 // static
 void ProximityAuthPrefManager::RegisterPrefs(PrefRegistrySimple* registry) {

[Tim Song, 2017/07/11 23:45:57]

We should take a PrefRegistrySyncable here to be more precise.

[sacomoto, 2017/07/12 15:52:53]

Done.

   registry->RegisterInt64Pref(prefs::kProximityAuthLastPasswordEntryTimestampMs,
                               0L);
   registry->RegisterDictionaryPref(prefs::kProximityAuthRemoteBleDevices);
+  registry->RegisterIntegerPref(
+      ::prefs::kEasyUnlockProximityThreshold, 1,

[Tim Song, 2017/07/11 23:45:57]

Move this to proximity_auth_pref_names in the component.

[sacomoto, 2017/07/12 15:52:53]

Done.

+      user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 }
 
 bool ProximityAuthPrefManager::HasDeviceWithAddress(
     const std::string& bluetooth_address) const {
   return pref_service_->GetDictionary(prefs::kProximityAuthRemoteBleDevices)
       ->HasKey(bluetooth_address);
 }
 
 bool ProximityAuthPrefManager::HasDeviceWithPublicKey(
     const std::string& public_key) const {
@@ skipping 74 matching lines @@
 int64_t ProximityAuthPrefManager::GetLastPasswordEntryTimestampMs() const {
   return pref_service_->GetInt64(
       prefs::kProximityAuthLastPasswordEntryTimestampMs);
 }
 
 const base::DictionaryValue* ProximityAuthPrefManager::GetRemoteBleDevices()
     const {
   return pref_service_->GetDictionary(prefs::kProximityAuthRemoteBleDevices);
 }
 
+void ProximityAuthPrefManager::SetProximityThreshold(ProximityThreshold value) {
+  pref_service_->SetInteger(::prefs::kEasyUnlockProximityThreshold, value);
+}
+
+ProximityAuthPrefManager::ProximityThreshold
+ProximityAuthPrefManager::GetProximityThreshold() const {
+  int pref_value =
+      pref_service_->GetInteger(::prefs::kEasyUnlockProximityThreshold);
+  return static_cast<ProximityThreshold>(pref_value);
+}
+
 }  // namespace proximity_auth