content/browser/background_fetch/background_fetch_test_base.cc - Issue 2973233002: [Background Fetch] Cleanup/fix thread safety

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_fetch/background_fetch_test_base.cc

Issue 2973233002: [Background Fetch] Cleanup/fix thread safety (Closed)

Patch Set: Remove n.b. from comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/background_fetch/background_fetch_test_base.cc

diff --git a/content/browser/background_fetch/background_fetch_test_base.cc b/content/browser/background_fetch/background_fetch_test_base.cc

index 9314f19e96e0d83b7c51618bc1d88b115e0d4e58..6d86edc8f043bc6c40b1746da73dbf71e3bdf147 100644

--- a/content/browser/background_fetch/background_fetch_test_base.cc

+++ b/content/browser/background_fetch/background_fetch_test_base.cc

@@ -201,6 +201,8 @@ class BackgroundFetchTestBase::RespondingDownloadManager

};

BackgroundFetchTestBase::BackgroundFetchTestBase()

+ // Using REAL_IO_THREAD would give better coverage for thread safety, but

+ // at time of writing EmbeddedWorkerTestHelper didn't seem to support that.

: thread_bundle_(TestBrowserThreadBundle::IO_MAINLOOP),

origin_(GURL(kTestOrigin)) {}