content/browser/background_fetch/background_fetch_job_controller_unittest.cc - Issue 2973233002: [Background Fetch] Cleanup/fix thread safety

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_fetch/background_fetch_job_controller_unittest.cc

Issue 2973233002: [Background Fetch] Cleanup/fix thread safety (Closed)

Patch Set: Remove n.b. from comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_fetch/background_fetch_job_controller.cc ('k') | content/browser/background_fetch/background_fetch_request_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_fetch/background_fetch_job_controller_unittest.cc

diff --git a/content/browser/background_fetch/background_fetch_job_controller_unittest.cc b/content/browser/background_fetch/background_fetch_job_controller_unittest.cc

index 2f0527f781d0778069eed2b9030d1b9317eefceb..201299eba207abbcdbb3a6a22dd6d90af81824ff 100644

--- a/content/browser/background_fetch/background_fetch_job_controller_unittest.cc

+++ b/content/browser/background_fetch/background_fetch_job_controller_unittest.cc

@@ -84,6 +84,8 @@ class BackgroundFetchJobControllerTest : public BackgroundFetchTestBase {

// Creates a new BackgroundFetchJobController instance.

std::unique_ptr<BackgroundFetchJobController> CreateJobController(

const BackgroundFetchRegistrationId& registration_id) {

+ // StoragePartition creates its own BackgroundFetchContext, but this test

+ // doesn't use that; it just uses the StoragePartition's URLRequestContext.

StoragePartition* storage_partition =

BrowserContext::GetDefaultStoragePartition(browser_context());