Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: content/browser/background_fetch/background_fetch_test_base.cc

Issue 2973233002: [Background Fetch] Cleanup/fix thread safety (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_test_base.cc
diff --git a/content/browser/background_fetch/background_fetch_test_base.cc b/content/browser/background_fetch/background_fetch_test_base.cc
index 9314f19e96e0d83b7c51618bc1d88b115e0d4e58..548310228605b49154f8c860bf4de98bbc31e890 100644
--- a/content/browser/background_fetch/background_fetch_test_base.cc
+++ b/content/browser/background_fetch/background_fetch_test_base.cc
@@ -201,6 +201,7 @@ class BackgroundFetchTestBase::RespondingDownloadManager
};
BackgroundFetchTestBase::BackgroundFetchTestBase()
+ // TODO(johnme): Make this REAL_IO_THREAD to get coverage for thread safety.
Peter Beverloo 2017/07/10 13:13:21 Is that ever going to happen? OK if you plan to wo
johnme 2017/07/10 13:41:07 Changed this to explain why it's not REAL_IO_THREA
: thread_bundle_(TestBrowserThreadBundle::IO_MAINLOOP),
origin_(GURL(kTestOrigin)) {}

Powered by Google App Engine
This is Rietveld 408576698