Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 297323003: Gallery.app: Fix image rotation in the image editor. (Closed)

Created:
6 years, 7 months ago by hirono
Modified:
6 years, 6 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Gallery.app: Fix image rotation in the image editor. There patch fixes the following two bugs. 1. The main cause: we assign null to metadata if we failed to fetch the data. But old code check the existance of data by using the 'in' operator and null value passes the check unexpectedlly. 2. Specifying OVER_FILL instead of FILL for an image in a tile of the mosaic view in case that the thumbnail image is samller than the tile. BUG=375676 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_encoder.js View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/mosaic_mode.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 7 months ago (2014-05-26 09:02:17 UTC) #1
mtomasz
LGTM. Sorry for the belated response!
6 years, 6 months ago (2014-05-27 06:12:24 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 6 months ago (2014-05-27 06:13:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/297323003/1
6 years, 6 months ago (2014-05-27 06:13:37 UTC) #4
hirono
On 2014/05/27 06:12:24, mtomasz wrote: > LGTM. Sorry for the belated response! No problem, thank ...
6 years, 6 months ago (2014-05-27 06:13:45 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 6 months ago (2014-05-27 08:11:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-27 09:33:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157089)
6 years, 6 months ago (2014-05-27 09:33:06 UTC) #8
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 6 months ago (2014-05-28 02:04:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/297323003/1
6 years, 6 months ago (2014-05-28 02:04:46 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 03:17:48 UTC) #11
Message was sent while issue was closed.
Change committed as 273139

Powered by Google App Engine
This is Rietveld 408576698