ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc - Issue 2973173002: Fix crashes when using translate in incognito by overriding some methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc

Issue 2973173002: Fix crashes when using translate in incognito by overriding some methods. (Closed)

Patch Set: addressed ichikawa comments Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/web_view/internal/translate/web_view_translate_accept_languages_factory.h ('k') | ios/web_view/internal/translate/web_view_translate_ranker_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc

diff --git a/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc b/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc

index 1e24463429186cb982d55c4f66d0f87c9336e14e..5a2f0622ab38d4147691686b3d17392e90595f3f 100644

--- a/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc

+++ b/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc

@@ -76,4 +76,10 @@ WebViewTranslateAcceptLanguagesFactory::BuildServiceInstanceFor(

browser_state->GetPrefs());

}

+web::BrowserState* WebViewTranslateAcceptLanguagesFactory::GetBrowserStateToUse(

+ web::BrowserState* context) const {

+ // Override to enable this service for off the record browser states.

+ return context;

} // namespace ios_web_view