Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: ios/web_view/internal/translate/web_view_translate_ranker_factory.cc

Issue 2973173002: Fix crashes when using translate in incognito by overriding some methods. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
diff --git a/ios/web_view/internal/translate/web_view_translate_ranker_factory.cc b/ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
index 8c701968a8f4363484c736e59785cbc177f9c1cb..0fe9936a1860f4d87cfea47ddeb6bcd68af103dc 100644
--- a/ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
+++ b/ios/web_view/internal/translate/web_view_translate_ranker_factory.cc
@@ -53,4 +53,9 @@ WebViewTranslateRankerFactory::BuildServiceInstanceFor(
return std::move(ranker);
}
+web::BrowserState* WebViewTranslateRankerFactory::GetBrowserStateToUse(
+ web::BrowserState* context) const {
+ return context;
Hiroshi Ichikawa 2017/07/07 05:15:21 Can you add a comment explaining that this class o
jzw1 2017/07/07 06:20:44 Done.
+}
+
} // namespace ios_web_view

Powered by Google App Engine
This is Rietveld 408576698