Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2973153002: [VM Parser] Fix parsing of new function type syntax. (Closed)

Created:
3 years, 5 months ago by regis
Modified:
3 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[VM Parser] Fix parsing of new function type syntax (Fixes #30092). Add regression test. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f78076d595b0fa11306deede981477733183576d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M runtime/vm/parser.cc View 2 chunks +9 lines, -3 lines 0 comments Download
A tests/language/regress_30092_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
regis
3 years, 5 months ago (2017-07-06 22:15:03 UTC) #3
siva
lgtm
3 years, 5 months ago (2017-07-07 01:02:27 UTC) #4
regis
3 years, 5 months ago (2017-07-07 01:17:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f78076d595b0fa11306deede981477733183576d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698