Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2973073003: fix fasta scanner comment processing (Closed)

Created:
3 years, 5 months ago by danrubel
Modified:
3 years, 5 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix fasta scanner comment processing fixes python tools/test.py -m release -c dart2analyzer -r none -a x64 --host-checked language/illegal_declaration_test/01 R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/76779e720d51bc7af059802168a4dbdfbc7afcc9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 5 months ago (2017-07-06 18:57:18 UTC) #2
Paul Berry
lgtm
3 years, 5 months ago (2017-07-06 19:06:23 UTC) #3
danrubel
3 years, 5 months ago (2017-07-06 19:08:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
76779e720d51bc7af059802168a4dbdfbc7afcc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698