Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: pkg/compiler/lib/src/parser/element_listener.dart

Issue 2973053002: Rename special dart2js error codes. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/fasta_codes_generated.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/parser/element_listener.dart
diff --git a/pkg/compiler/lib/src/parser/element_listener.dart b/pkg/compiler/lib/src/parser/element_listener.dart
index 7e23b1e5f9b381fe2024e02a554c95a9a1df10f1..c381ba6e72942ef9efe0cf910497424fea7ac0d2 100644
--- a/pkg/compiler/lib/src/parser/element_listener.dart
+++ b/pkg/compiler/lib/src/parser/element_listener.dart
@@ -582,10 +582,6 @@ class ElementListener extends Listener {
}
return newSyntheticToken(token);
- case "FASTA_FATAL":
- reportFatalError(reporter.spanFromToken(token), message.message);
- return null;
-
case "NATIVE_OR_BODY_EXPECTED":
if (optional("native", token)) {
return newSyntheticToken(native.handleNativeBlockToSkip(this, token));
@@ -705,8 +701,17 @@ class ElementListener extends Listener {
errorCode = MessageKind.UNTERMINATED_TOKEN;
break;
- case "FASTA_IGNORED":
- return null; // Ignored. This error is already implemented elsewhere.
+ case "*fatal*":
+ // This is an error that Fasta can recover from, but dart2js can't.
+ reportFatalError(reporter.spanFromToken(token), message.message);
+ return null;
+
+ case "*ignored*":
+ // This is an error that Fasta reports as a recoverable error during
+ // parsing. For historical reasons, dart2js implements this in a later
+ // phase already, so we just ignore it. Another possibilty is that we
+ // wan't to avoid introducing a breaking change to dart2js.
+ return null;
default:
throw "Unexpected message code: ${message.code}";
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/fasta_codes_generated.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698