Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 297303012: Updated ARM test specs (Closed)

Created:
6 years, 6 months ago by nodir
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Updated ARM test specs Since chromium and chromium_trybot recipes expect different test spec file format, chromium_arm.json cannot be used by chromium isolate, so duplicating the test spec in chromium.fyi.json. Also we might want different set of tests in these recipes. Test spec may have compile targets. Had to change chromium_arm.json and chromium_trybot.json format to include them. For backward compatibility, chromium_trybot recipe will continue accepting an array as a test spec, until this is committed. After that the old format support will be removed. Removed cmd line args from chromium_arm.json because at the moment they cannot be transferred to a tester with the current infrastructure. Removed descriptions (comments) from test specs per phajdan.jr's request. R=phajdan.jr@chromium.org, vadimsh@chromium.org BUG=359338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273746

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : args must be lists #

Total comments: 2

Patch Set 4 : moved compile_targets #

Patch Set 5 : removed args #

Patch Set 6 : removed descriptions #

Total comments: 2

Patch Set 7 : nit #

Patch Set 8 : cleaned up CL description #

Total comments: 5

Patch Set 9 : #

Patch Set 10 : more nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -129 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_arm.json View 1 2 3 4 5 6 1 chunk +8 lines, -10 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 2 3 1 chunk +121 lines, -119 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
nodir
PTAL
6 years, 6 months ago (2014-05-28 21:13:03 UTC) #1
Paweł Hajdan Jr.
https://codereview.chromium.org/297303012/diff/30001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/297303012/diff/30001/testing/buildbot/chromium.fyi.json#newcode215 testing/buildbot/chromium.fyi.json:215: "compile_targets": ["browser_tests_run"] Please pull compile_targets out of "gtest_tests" (just ...
6 years, 6 months ago (2014-05-29 16:22:43 UTC) #2
Paweł Hajdan Jr.
Patch Set 6 LGTM with a comment Please don't make other changes. I'm open to ...
6 years, 6 months ago (2014-05-29 17:22:07 UTC) #3
Vadim Sh.
Please cleanup CL description before committing. It currently looks like two commits squashed.
6 years, 6 months ago (2014-05-29 20:49:38 UTC) #4
nodir
Sorry about that, updated the description https://codereview.chromium.org/297303012/diff/90001/testing/buildbot/chromium_arm.json File testing/buildbot/chromium_arm.json (right): https://codereview.chromium.org/297303012/diff/90001/testing/buildbot/chromium_arm.json#newcode5 testing/buildbot/chromium_arm.json:5: "gtest_tests": [{ On ...
6 years, 6 months ago (2014-05-29 21:00:11 UTC) #5
Vadim Sh.
lgtm with nits https://codereview.chromium.org/297303012/diff/150001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/297303012/diff/150001/testing/buildbot/chromium.fyi.json#newcode206 testing/buildbot/chromium.fyi.json:206: 'Linux ARM Cross-Compile': { nit: "Linux ...
6 years, 6 months ago (2014-05-29 21:06:01 UTC) #6
nodir
Done, thanks! Pawel, these changes were necessary, otherwise this'd break something https://codereview.chromium.org/297303012/diff/150001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): ...
6 years, 6 months ago (2014-05-29 21:15:31 UTC) #7
nodir
The CQ bit was checked by nodir@chromium.org
6 years, 6 months ago (2014-05-29 22:08:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nodir@chromium.org/297303012/190001
6 years, 6 months ago (2014-05-29 22:10:29 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 02:32:35 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 07:10:16 UTC) #11
Message was sent while issue was closed.
Change committed as 273746

Powered by Google App Engine
This is Rietveld 408576698