Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297303004: Revert 21502 - "Move OS::MemCopy and OS::MemMove out of platform to utils" (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Revert 21502 - "Move OS::MemCopy and OS::MemMove out of platform to utils" TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21504

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -327 lines) Patch
M src/allocation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/assembler-arm.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/arm/codegen-arm.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M src/arm/constants-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 10 chunks +25 lines, -25 lines 0 comments Download
M src/atomicops_internals_x86_gcc.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/builtins.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/conversions-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/execution.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/flags.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gdb-jit.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/heap-inl.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/hydrogen-check-elimination.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/hydrogen-gvn.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/isolate.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/list-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lithium-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/log.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips/assembler-mips.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/codegen-mips.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/mips/simulator-mips.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform.h View 2 chunks +84 lines, -0 lines 0 comments Download
M src/platform-posix.cc View 1 chunk +66 lines, -0 lines 0 comments Download
M src/platform-win32.cc View 3 chunks +34 lines, -1 line 0 comments Download
M src/preparse-data.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/prettyprinter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp-macro-assembler-irregexp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp-stack.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M src/scanner.h View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.h View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/unicode-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/utils.h View 12 chunks +20 lines, -98 lines 0 comments Download
M src/utils.cc View 3 chunks +3 lines, -64 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/codegen-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/deoptimizer-x87.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-utils.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-26 19:56:14 UTC) #1
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r21504 (presubmit successful).
6 years, 7 months ago (2014-05-26 19:57:04 UTC) #2
Jakob Kummerow
6 years, 7 months ago (2014-05-27 07:39:35 UTC) #3
Message was sent while issue was closed. 
rubberstamp LGTM

Powered by Google App Engine
This is Rietveld 408576698