Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 297303003: Revert of non-new-profile-management creates a "no-op" style account_reconcilor, (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Revert of non-new-profile-management creates a "no-op" style account_reconcilor, (https://codereview.chromium.org/276463002/) Reason for revert: unit tests fail on mac Original issue's description: > non-new-profile-management creates a "no-op" style account_reconcilor, > useful for tracking stats but won't have any real effects. > > Modify the AccountReconcilor_unittest to execute with the new_profile_management flag on. > > BUG=357693 > TEST=Account Reconciler should function normally when > new_profile_management flag is on. Should not have effects when the > flag is off, but UMA stats (histograms) and logging (for > --vmodule=account_reconcilor=1) should still trace the execution path. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272131 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272826 NOTRY=true NOTREECHECKS=true TBR=mlerman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272859

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -90 lines) Patch
M chrome/browser/profiles/profile_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 10 chunks +14 lines, -36 lines 0 comments Download
M components/signin/core/browser/account_reconcilor.h View 1 chunk +2 lines, -5 lines 0 comments Download
M components/signin/core/browser/account_reconcilor.cc View 6 chunks +13 lines, -33 lines 0 comments Download
M google_apis/gaia/fake_gaia.h View 1 chunk +0 lines, -2 lines 0 comments Download
M google_apis/gaia/fake_gaia.cc View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of non-new-profile-management creates a "no-op" style account_reconcilor,
6 years, 7 months ago (2014-05-26 18:24:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/297303003/1
6 years, 7 months ago (2014-05-26 18:25:27 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 18:25:28 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-26 18:25:28 UTC) #4
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-26 18:33:03 UTC) #5
jochen (gone - plz use gerrit)
The CQ bit was unchecked by jochen@chromium.org
6 years, 7 months ago (2014-05-26 18:33:08 UTC) #6
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 7 months ago (2014-05-26 18:33:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/297303003/1
6 years, 7 months ago (2014-05-26 18:34:11 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 18:35:44 UTC) #9
Message was sent while issue was closed.
Change committed as 272859

Powered by Google App Engine
This is Rietveld 408576698