Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6071)

Unified Diff: chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm

Issue 2973006: Use the extension icon for extension omnibox results instead of the generic (Closed)
Patch Set: fixed mac Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
diff --git a/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm b/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
index 44e223bd44fc26d953d1e5e86f25519aa029a9df..ee3565fc15bd2ebbc59dcdb6a3de55b6e173138c 100644
--- a/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
+++ b/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm
@@ -266,6 +266,7 @@ TEST_F(AutocompleteTextFieldTest, Display) {
[field_ display];
[cell clearHint];
+
[field_ display];
}
@@ -382,6 +383,7 @@ TEST_F(AutocompleteTextFieldTest, ResetFieldEditorKeywordHint) {
// Capture the editor frame resulting from the standard focus
// machinery.
+
[test_window() makePretendKeyWindowAndSetFirstResponder:field_];
const NSRect baseEditorFrame(EditorFrame());
@@ -398,6 +400,7 @@ TEST_F(AutocompleteTextFieldTest, ResetFieldEditorKeywordHint) {
mock_left_decoration_.SetVisible(true);
EXPECT_FALSE(NSIsEmptyRect([cell frameForDecoration:&mock_left_decoration_
inFrame:[field_ bounds]]));
+
[field_ resetFieldEditorFrameIfNeeded];
EXPECT_TRUE(NSEqualRects(baseEditorFrame, EditorFrame()));
}
@@ -457,6 +460,7 @@ TEST_F(AutocompleteTextFieldTest, ClickLeftDecorationPutsCaretLeftmost) {
// Set the decoration before becoming responder.
EXPECT_FALSE([field_ currentEditor]);
mock_left_decoration_.SetVisible(true);
+ NSImage* image = [NSImage imageNamed:@"NSApplicationIcon"];
// Make first responder should select all.
[test_window() makePretendKeyWindowAndSetFirstResponder:field_];

Powered by Google App Engine
This is Rietveld 408576698