Chromium Code Reviews
Help | Chromium Project | Sign in
(10)

Issue 2973003: [Mac] Finish up extension infobar UI implementation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Andrew Bonventre (Bons)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Aaron Boodman, arv, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Mac] Finish up extension infobar UI implementation. o One issue under consideration is whether the HTML content of the infobar can take up the entire width. Right now on Windows it does not but with this implementation (and on Linux) it does. BUG=43168 TEST=ExtensionApiTest.Infobars Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52182

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 24

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -19 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/cocoa/extensions/extension_action_context_menu.h View 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/cocoa/extensions/extension_action_context_menu.mm View 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/extensions/extension_infobar_controller.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/extensions/extension_infobar_controller.mm View 1 2 6 chunks +158 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_infobar_apitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A chrome/browser/resources/extensions_infobar_mac.css View 1 1 chunk +13 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Andrew Bonventre (Bons)
4 years, 10 months ago (2010-07-10 22:10:54 UTC) #1
Mark Mentovai - out til August
LG with these changes. http://codereview.chromium.org/2973003/diff/5001/6001 File chrome/browser/browser_resources.grd (right): http://codereview.chromium.org/2973003/diff/5001/6001#newcode37 chrome/browser/browser_resources.grd:37: <include name="IDR_EXTENSIONS_INFOBAR_CSS_MAC" file="resources\extensions_infobar_mac.css" flattenhtml="true" type="BINDATA" ...
4 years, 10 months ago (2010-07-12 18:45:59 UTC) #2
Andrew Bonventre (Bons)
Done and enabled the API test. http://codereview.chromium.org/2973003/diff/5001/6001 File chrome/browser/browser_resources.grd (right): http://codereview.chromium.org/2973003/diff/5001/6001#newcode37 chrome/browser/browser_resources.grd:37: <include name="IDR_EXTENSIONS_INFOBAR_CSS_MAC" file="resources\extensions_infobar_mac.css" ...
4 years, 10 months ago (2010-07-12 21:39:47 UTC) #3
Mark Mentovai - out til August
4 years, 10 months ago (2010-07-12 21:49:30 UTC) #4
LG™
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be