chrome/browser/cocoa/extensions/extension_action_context_menu.mm - Issue 2973003: [Mac] Finish up extension infobar UI implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/extensions/extension_action_context_menu.mm

Issue 2973003: [Mac] Finish up extension infobar UI implementation. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/extensions/extension_action_context_menu.mm

===================================================================

--- chrome/browser/cocoa/extensions/extension_action_context_menu.mm (revision 52101)

+++ chrome/browser/cocoa/extensions/extension_action_context_menu.mm (working copy)

@@ -243,6 +243,7 @@

(AutocompleteTextField*)locationBar->location_entry()->

GetNativeView();

AutocompleteTextFieldCell* fieldCell = [field autocompleteTextFieldCell];

+ DCHECK(action_);

NSRect popupRect =

[fieldCell pageActionFrameForExtensionAction:action_

inFrame:[field bounds]];

@@ -276,8 +277,8 @@

}

- (BOOL)validateMenuItem:(NSMenuItem*)menuItem {

- if([menuItem isEqualTo: inspectorItem_.get()]) {

- return (action_->HasPopup(CurrentTabId()));

+ if([menuItem isEqualTo:inspectorItem_.get()]) {

+ return action_ && action_->HasPopup(CurrentTabId());

}

return YES;

}