Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 297293007: Remove unimplemented nodeUnderMouse() method from EventHandler.h (Closed)

Created:
6 years, 6 months ago by Sunil Ratnu
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unimplemented nodeUnderMouse() method from EventHandler.h nodeUnderMouse function is unimplemented in the complete code, so removing it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/page/EventHandler.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sunil Ratnu
Please have a look.
6 years, 6 months ago (2014-05-27 15:36:51 UTC) #1
Sunil Ratnu
Hi Darin, since abarth seems to be OOO, PTAL.
6 years, 6 months ago (2014-05-30 05:41:32 UTC) #2
eseidel
lgtm
6 years, 6 months ago (2014-05-30 06:08:21 UTC) #3
eseidel
6 years, 6 months ago (2014-05-30 06:08:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sunil.ratnu@samsung.com/297293007/1
6 years, 6 months ago (2014-05-30 06:12:03 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 10:48:14 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 13:00:22 UTC) #7
Message was sent while issue was closed.
Change committed as 175119

Powered by Google App Engine
This is Rietveld 408576698