Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: icu.gyp

Issue 297293005: Add missing linker dependency on advapi32.lib for icuuc target. (Closed) Base URL: https://src.chromium.org/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'icu.gypi', 7 'icu.gypi',
8 ], 8 ],
9 'variables': { 9 'variables': {
10 'use_system_icu%': 0, 10 'use_system_icu%': 0,
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 'source/common', 270 'source/common',
271 ], 271 ],
272 'conditions': [ 272 'conditions': [
273 [ 'component=="static_library"', { 273 [ 'component=="static_library"', {
274 'defines': [ 274 'defines': [
275 'U_STATIC_IMPLEMENTATION', 275 'U_STATIC_IMPLEMENTATION',
276 ], 276 ],
277 }], 277 }],
278 ], 278 ],
279 }, 279 },
280 'all_dependent_settings': {
281 'msvs_settings': {
282 'VCLinkerTool': {
283 'AdditionalDependencies': [
284 'advapi32.lib',
285 ],
286 },
287 },
288 },
280 'conditions': [ 289 'conditions': [
281 [ 'use_system_icu==1 and want_separate_host_toolset==1', { 290 [ 'use_system_icu==1 and want_separate_host_toolset==1', {
282 'toolsets': ['host'], 291 'toolsets': ['host'],
283 }], 292 }],
284 [ 'use_system_icu==0 and want_separate_host_toolset==1', { 293 [ 'use_system_icu==0 and want_separate_host_toolset==1', {
285 'toolsets': ['host', 'target'], 294 'toolsets': ['host', 'target'],
286 }], 295 }],
287 [ 'use_system_icu==0 and want_separate_host_toolset==0', { 296 [ 'use_system_icu==0 and want_separate_host_toolset==0', {
288 'toolsets': ['target'], 297 'toolsets': ['target'],
289 }], 298 }],
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 }, 604 },
596 'includes': [ 605 'includes': [
597 '../../build/shim_headers.gypi', 606 '../../build/shim_headers.gypi',
598 ], 607 ],
599 'toolsets': ['target'], 608 'toolsets': ['target'],
600 }, 609 },
601 ], # targets 610 ], # targets
602 }], 611 }],
603 ], # conditions 612 ], # conditions
604 } 613 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698