Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 2972873002: Create more synthetic kernel objects. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create more synthetic kernel objects. This CL creates synthetic kernel objects for two additional BodyBuilder corner cases: - The synthetic "throw" expression created when code attempts to construct an abstract class. - The "throw" expression created when code attempts to assign to a read-only expression. With this change, we now create a KernelComplexAssignment object for all assignments; this has allowed me to streamline the code for creating assignments slightly. R=ahe@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b38e4d9a70cf2225928eb624c099aca3f2d05c3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -41 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 8 chunks +15 lines, -35 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/abstract_class_instantiation.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/abstract_class_instantiation.dart.direct.expect View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/abstract_class_instantiation.dart.outline.expect View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/strong.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
Konstantin to do preliminary review since he's on west coast time Peter to do final ...
3 years, 5 months ago (2017-07-06 20:10:05 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-06 20:14:11 UTC) #3
ahe
lgtm
3 years, 5 months ago (2017-07-06 20:45:13 UTC) #4
Paul Berry
3 years, 5 months ago (2017-07-06 20:51:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b38e4d9a70cf2225928eb624c099aca3f2d05c3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698