Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2972833002: Initial implementation of copy/paste support (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
devoncarew
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -119 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol.dart View 2 chunks +20 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_constants.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_generated.dart View 18 chunks +17 lines, -75 lines 0 comments Download
A pkg/analysis_server/lib/src/computer/import_elements_computer.dart View 1 chunk +54 lines, -0 lines 2 comments Download
A pkg/analysis_server/lib/src/computer/imported_elements_computer.dart View 1 chunk +43 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +30 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 3 chunks +30 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/get_imported_elements_test.dart View 1 chunk +76 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/coverage.md View 2 chunks +2 lines, -2 lines 0 comments Download
A pkg/analysis_server/test/integration/edit/import_elements_test.dart View 1 chunk +73 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/test_all.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/support/integration_test_methods.dart View 3 chunks +5 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/integration/support/protocol_matchers.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/RequestErrorCode.java View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 4 chunks +13 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
This removes the "complete" field that appears to be unneeded, specified a new error, provides ...
3 years, 5 months ago (2017-07-05 15:26:19 UTC) #2
devoncarew
lgtm https://codereview.chromium.org/2972833002/diff/1/pkg/analysis_server/lib/src/computer/import_elements_computer.dart File pkg/analysis_server/lib/src/computer/import_elements_computer.dart (right): https://codereview.chromium.org/2972833002/diff/1/pkg/analysis_server/lib/src/computer/import_elements_computer.dart#newcode51 pkg/analysis_server/lib/src/computer/import_elements_computer.dart:51: builder.addFileEdit(path, (DartFileEditBuilder builder) {}); This is the stub ...
3 years, 5 months ago (2017-07-05 20:54:59 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2972833002/diff/1/pkg/analysis_server/lib/src/computer/import_elements_computer.dart File pkg/analysis_server/lib/src/computer/import_elements_computer.dart (right): https://codereview.chromium.org/2972833002/diff/1/pkg/analysis_server/lib/src/computer/import_elements_computer.dart#newcode51 pkg/analysis_server/lib/src/computer/import_elements_computer.dart:51: builder.addFileEdit(path, (DartFileEditBuilder builder) {}); Done
3 years, 5 months ago (2017-07-05 21:01:50 UTC) #4
Brian Wilkerson
3 years, 5 months ago (2017-07-05 21:02:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d9754a58e9c2cc25a4b46672d57979095a41d7eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698