Fix did_replace_entry reported as false for meta refresh tags

content/browser/frame_host/navigation_controller_impl.cc

Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index f15af73e7d65241e8125e0f1f27af6dd9a1ed046..2096bfb6ebac95f2cf87a055d8af49c53e09daf9 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -888,7 +888,8 @@ bool NavigationControllerImpl::RendererDidNavigate(
                                    navigation_handle);
       break;
     case NAVIGATION_TYPE_EXISTING_PAGE:
-      details->did_replace_entry = details->is_same_document;
+      details->did_replace_entry =
+          details->did_replace_entry || details->is_same_document;

[Charlie Reis, 2017/07/07 22:52:55]

Might be cleaner to rephrase it as:

if (details->is_same_document)
  details->did_replace_entry = true;

or even:
details->did_replace_entry |= details->is_same_document;

Either way, it's worth having a comment saying why is_same_document implies that
it replaced the entry.  I'm having trouble understanding why that's the case,
though (even before Avi's CL, when it was something about the page ID not
changing).

       RendererDidNavigateToExistingPage(rfh, params, details->is_same_document,
                                         was_restored, navigation_handle);
       break;