Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: tools/ipc_fuzzer/message_replay/replay_process.cc

Issue 2972773004: Remove ScopedVector from tools/ipc_fuzzer/. (Closed)
Patch Set: rev Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/ipc_fuzzer/message_replay/replay_process.cc
diff --git a/tools/ipc_fuzzer/message_replay/replay_process.cc b/tools/ipc_fuzzer/message_replay/replay_process.cc
index 325382e9ca4551507b8b620f48a1ff5747c1dad7..1a862cd3e3579abdee56c1d8c86f9dea2e58ca66 100644
--- a/tools/ipc_fuzzer/message_replay/replay_process.cc
+++ b/tools/ipc_fuzzer/message_replay/replay_process.cc
@@ -5,7 +5,9 @@
#include "tools/ipc_fuzzer/message_replay/replay_process.h"
#include <limits.h>
+
#include <string>
+#include <utility>
#include "base/bind.h"
#include "base/command_line.h"
@@ -129,11 +131,10 @@ void ReplayProcess::SendNextMessage() {
return;
}
- // Take next message and release it from vector.
- IPC::Message* message = messages_[message_index_];
- messages_[message_index_++] = NULL;
+ std::unique_ptr<IPC::Message> message =
+ std::move(messages_[message_index_++]);
- if (!channel_->Send(message)) {
+ if (!channel_->Send(message.release())) {
Tom Sepez 2017/07/10 17:45:47 ah, pity Send() doesn't take unique_ptr itself ...
Avi (use Gerrit) 2017/07/10 18:44:00 If we weren't moving to Mojo and obviating that, t
LOG(ERROR) << "ChannelProxy::Send() failed after "
<< message_index_ << " messages";
base::MessageLoop::current()->QuitWhenIdle();

Powered by Google App Engine
This is Rietveld 408576698