chrome/browser/resources/md_bookmarks/item.js - Issue 2972773003: MD Bookmarks: Always select targeted item during doubleclick

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_bookmarks/item.js

Issue 2972773003: MD Bookmarks: Always select targeted item during doubleclick (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/md_bookmarks/item.js

diff --git a/chrome/browser/resources/md_bookmarks/item.js b/chrome/browser/resources/md_bookmarks/item.js

index 7f0466f356afb002d65d0b6ce0c1c2b0e9370288..6b8cedbd85e93f5d7054fff7d7ff4cbc67e17d97 100644

--- a/chrome/browser/resources/md_bookmarks/item.js

+++ b/chrome/browser/resources/md_bookmarks/item.js

@@ -148,6 +148,8 @@ Polymer({

* @private

onDblClick_: function(e) {

+ if (!this.isSelectedItem_)

+ this.selectThisItem_();

calamity 2017/07/06 08:08:58 nit: newline

tsergeant 2017/07/06 08:23:22 Done.

var commandManager = bookmarks.CommandManager.getInstance();

var itemSet = this.getState().selection.items;

if (commandManager.canExecute(Command.OPEN, itemSet))

« no previous file with comments | « no previous file | chrome/test/data/webui/md_bookmarks/item_test.js » ('j') | no next file with comments »