Make FrameSelection::MoveRangeSelection() not to set live granularity selection

third_party/WebKit/Source/core/editing/FrameSelection.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1118 matching lines @@
           .SetBaseAndExtentDeprecated(base_position.DeepEquivalent(),
                                       extent_position.DeepEquivalent())
           .SetAffinity(base_position.Affinity())
           .SetGranularity(granularity)
           .SetIsHandleVisible(IsHandleVisible())
           .Build();
 
   if (new_selection.IsNone())
     return;
 
-  SetSelection(new_selection, kCloseTyping | kClearTypingStyle,
+  const VisibleSelection visible_selection =
+      CreateVisibleSelection(new_selection);

[yoichio, 2017/07/06 02:26:32]

nlgtm
Is this not VSinflattree?

[yosin_UTC9, 2017/07/06 03:24:21]

Talked offline.
We should use flat tree version of position/range/selection in core/editing,
except for core/editing/commands; for backward compatibility reasons[1].

In the meantime, we keep them as is, purely priority reasons.

[1] http://crbug.com/739591 ⚐	Change DOM tree traversal to flat tree traversal
in editing

+  if (visible_selection.IsNone())
+    return;
+
+  SelectionInDOMTree::Builder builder;
+  if (visible_selection.IsBaseFirst()) {
+    builder.SetBaseAndExtent(visible_selection.Start(),
+                             visible_selection.End());
+  } else {
+    builder.SetBaseAndExtent(visible_selection.End(),
+                             visible_selection.Start());
+  }
+  builder.SetAffinity(visible_selection.Affinity());
+  builder.SetIsHandleVisible(IsHandleVisible());
+  SetSelection(builder.Build(), kCloseTyping | kClearTypingStyle,
                CursorAlignOnScroll::kIfNeeded, granularity);
 }
 
 void FrameSelection::SetCaretVisible(bool caret_is_visible) {
   frame_caret_->SetCaretVisibility(caret_is_visible ? CaretVisibility::kVisible
                                                     : CaretVisibility::kHidden);
 }
 
 void FrameSelection::SetCaretBlinkingSuspended(bool suspended) {
   frame_caret_->SetCaretBlinkingSuspended(suspended);
@@ skipping 32 matching lines @@
 }
 
 void showTree(const blink::FrameSelection* sel) {
   if (sel)
     sel->ShowTreeForThis();
   else
     LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
 }
 
 #endif