Creates common super class for bookmark handset and tablet view controllers

ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm

Index: ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..baa0b167090bbe89bf71f7eeec58727edc25bab8
--- /dev/null
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller_unittest.mm
@@ -0,0 +1,60 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h"

[lpromero, 2017/07/07 13:30:09]

Add a new line below, or else sort-headers will mix it among the others.

[ramyasharma, 2017/07/10 06:55:59]

Done.

+#import "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
+#include "ios/chrome/browser/ui/bookmarks/bookmark_ios_unittest.h"
+
+// A partial mock subclass that doesn't load any heavy weight subclasses.
+@interface MockBookmarkHomeViewController : BookmarkHomeViewController

[noyau (Ping after 24h), 2017/07/07 09:37:24]

I don't understand why you don't use BookmarkHomeViewController directly?

[ramyasharma, 2017/07/10 06:55:59]

This was just copied from the other test class. Going with the real class now.
thanks

+@end
+
+@implementation MockBookmarkHomeViewController
+
+@end
+
+namespace {
+
+using BookmarkHomeViewControllerTest = BookmarkIOSUnitTest;
+
+TEST_F(BookmarkHomeViewControllerTest, LoadBookmarks) {
+  @autoreleasepool {
+    MockBookmarkHomeViewController* controller =
+        [[MockBookmarkHomeViewController alloc]
+            initWithLoader:nil
+              browserState:chrome_browser_state_.get()];
+
+    EXPECT_TRUE(controller.menuView == nil);

[lpromero, 2017/07/07 13:30:10]

Optional nit:

EXPECT_EQ(nil, controller.menuView);

Using EXPECT_EQ/EXPECT_NE gives usually a better log when the expectation fails.

[ramyasharma, 2017/07/10 06:55:59]

Done.

+    EXPECT_TRUE(controller.panelView == nil);
+    EXPECT_TRUE(controller.folderView == nil);
+
+    [controller view];
+    [controller loadBookmarkViews];
+
+    EXPECT_TRUE(controller != nil);

[lpromero, 2017/07/07 13:30:09]

Related optional nit:

EXPECT_NE(nil, controller);

[ramyasharma, 2017/07/10 06:55:59]

Done.

+    EXPECT_TRUE(controller.navigationBar != nil);
+    EXPECT_TRUE(controller.menuView != nil);
+    EXPECT_TRUE(controller.panelView != nil);
+    EXPECT_TRUE(controller.folderView != nil);
+  }
+}
+
+TEST_F(BookmarkHomeViewControllerTest, LoadWaitingView) {
+  @autoreleasepool {
+    MockBookmarkHomeViewController* controller =
+        [[MockBookmarkHomeViewController alloc]
+            initWithLoader:nil
+              browserState:chrome_browser_state_.get()];
+
+    EXPECT_TRUE(controller.waitForModelView == nil);
+
+    [controller view];
+    [controller loadWaitingView];
+
+    EXPECT_TRUE(controller != nil);
+    EXPECT_TRUE(controller.waitForModelView != nil);
+  }
+}
+
+}  // namespace