Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h

Issue 2972733002: Creates common super class for bookmark handset and tablet view controllers (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h
diff --git a/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h b/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h
index 83bd477283ac44f9f0f462602f3d8274c3ad5aea..2d09e87f4436ad580766d34092c679c0cbc330bb 100644
--- a/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h
+++ b/ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.h
@@ -5,6 +5,8 @@
#ifndef IOS_CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_HOME_HANDSET_VIEW_CONTROLLER_H_
#define IOS_CHROME_BROWSER_UI_BOOKMARKS_BOOKMARK_HOME_HANDSET_VIEW_CONTROLLER_H_
+#import "ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.h"
+
#import <UIKit/UIKit.h>
#include <set>
@@ -16,14 +18,9 @@ class GURL;
@protocol UrlLoader;
namespace bookmarks {
-class BookmarkModel;
class BookmarkNode;
} // namespace bookmarks
-namespace ios {
-class ChromeBrowserState;
-} // namespace ios
-
@protocol BookmarkHomeHandsetViewControllerDelegate
// The view controller wants to be dismissed.
// If |url| != GURL(), then the user has selected |url| for navigation.
@@ -33,7 +30,7 @@ class ChromeBrowserState;
@end
// Navigate/edit the bookmark hierarchy on a handset.
-@interface BookmarkHomeHandsetViewController : UIViewController {
+@interface BookmarkHomeHandsetViewController : BookmarkHomeViewController {
@protected
// The following 2 ivars both represent the set of nodes being edited.
// The set is for fast lookup.
@@ -43,9 +40,6 @@ class ChromeBrowserState;
std::set<const bookmarks::BookmarkNode*> _editNodes;
std::vector<const bookmarks::BookmarkNode*> _editNodesOrdered;
}
-// Designated initializer.
-- (instancetype)initWithLoader:(id<UrlLoader>)loader
- browserState:(ios::ChromeBrowserState*)browserState;
#pragma mark - Properties Relevant To Presenters
@@ -57,9 +51,6 @@ class ChromeBrowserState;
@property(nonatomic, assign, readonly) BOOL editing;
// The set of selected index paths for edition.
@property(nonatomic, strong, readonly) NSMutableArray* editIndexPaths;
-@property(nonatomic, assign, readonly) bookmarks::BookmarkModel* bookmarks;
-@property(nonatomic, weak, readonly) id<UrlLoader> loader;
-@property(nonatomic, assign, readonly) ios::ChromeBrowserState* browserState;
#pragma mark - Relevant Methods
// Replaces |_editNodes| and |_editNodesOrdered| with new container objects.
« no previous file with comments | « ios/chrome/browser/ui/bookmarks/BUILD.gn ('k') | ios/chrome/browser/ui/bookmarks/bookmark_home_handset_view_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698