Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297273003: test_runner: Migrate WebTestRunner to our Chromium C++ style. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

test_runner: Migrate WebTestRunner to our Chromium C++ style. Changes: 1) Run clang-format through header file. 3) Fix method names to use CamelCase style. 4) Rename file name to web_test_runner. BUG=331299 TEST=content_unittests, content_shell. No functional changes TBR=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272853

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -88 lines) Patch
M content/content_shell.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/shell_render_frame_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/MockWebMIDIAccessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
D content/shell/renderer/test_runner/WebTestRunner.h View 1 chunk +0 lines, -42 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 2 chunks +7 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/shell/renderer/test_runner/web_test_runner.h View 1 chunk +21 lines, -21 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
TBRing...(please, rubber stamp).
6 years, 7 months ago (2014-05-26 03:37:36 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-26 03:37:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/297273003/20001
6 years, 7 months ago (2014-05-26 03:38:05 UTC) #3
commit-bot: I haz the power
Change committed as 272853
6 years, 7 months ago (2014-05-26 16:37:05 UTC) #4
Dirk Pranke
6 years, 6 months ago (2014-05-28 19:01:27 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698