Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2972663002: Mark max-device-aspect-ratio_t01 as flaky. (Closed)

Created:
3 years, 5 months ago by floitsch
Modified:
3 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark max-device-aspect-ratio_t01 as flaky. Committed: https://github.com/dart-lang/sdk/commit/89365d4d9ad9c7822f62811b7e0b0589ff2e78e5

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/co19/co19-dart2js.status View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
TBR.
3 years, 5 months ago (2017-07-04 14:11:55 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 89365d4d9ad9c7822f62811b7e0b0589ff2e78e5 (presubmit successful).
3 years, 5 months ago (2017-07-04 14:12:21 UTC) #4
Bill Hesse
lgtm https://codereview.chromium.org/2972663002/diff/1/tests/co19/co19-dart2js.status File tests/co19/co19-dart2js.status (right): https://codereview.chromium.org/2972663002/diff/1/tests/co19/co19-dart2js.status#newcode965 tests/co19/co19-dart2js.status:965: LayoutTests/fast/css/max-device-aspect-ratio_t01: RuntimeError, Pass # 28998 The standard is ...
3 years, 5 months ago (2017-07-04 14:32:35 UTC) #5
floitsch
3 years, 5 months ago (2017-07-05 14:04:15 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2972663002/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/2972663002/diff/1/tests/co19/co19-dart2js.sta...
tests/co19/co19-dart2js.status:965:
LayoutTests/fast/css/max-device-aspect-ratio_t01: RuntimeError, Pass # 28998
On 2017/07/04 14:32:35, Bill Hesse wrote:
> The standard is to say # Issue 28998

Done in https://codereview.chromium.org/2970073002/

Powered by Google App Engine
This is Rietveld 408576698