Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: components/favicon/core/favicon_handler.h

Issue 2972643002: Always prefer 192x192 on mobile, also for touch icons (Closed)
Patch Set: Removed comment. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 void OnFaviconDataForManifestFromFaviconService( 199 void OnFaviconDataForManifestFromFaviconService(
200 const std::vector<favicon_base::FaviconRawBitmapResult>& 200 const std::vector<favicon_base::FaviconRawBitmapResult>&
201 favicon_bitmap_results); 201 favicon_bitmap_results);
202 202
203 // Called when the dowloading of a manifest completes. 203 // Called when the dowloading of a manifest completes.
204 void OnDidDownloadManifest(const std::vector<FaviconURL>& candidates); 204 void OnDidDownloadManifest(const std::vector<FaviconURL>& candidates);
205 205
206 // Called when the actual list of favicon candidates to be processed is 206 // Called when the actual list of favicon candidates to be processed is
207 // available, which can be either icon URLs listed in the HTML head instead 207 // available, which can be either icon URLs listed in the HTML head instead
208 // or, if a Web Manifest was provided, the list of icons there. 208 // or, if a Web Manifest was provided, the list of icons there.
209 void OnGotFinalIconURLCandidates(const std::vector<FaviconURL>& candidates, 209 void OnGotFinalIconURLCandidates(const std::vector<FaviconURL>& candidates);
210 const std::vector<int>& desired_pixel_sizes);
211 210
212 // Called when the history request for favicon data mapped to |url_| has 211 // Called when the history request for favicon data mapped to |url_| has
213 // completed and the renderer has told us the icon URLs used by |url_| 212 // completed and the renderer has told us the icon URLs used by |url_|
214 void OnGotInitialHistoryDataAndIconURLCandidates(); 213 void OnGotInitialHistoryDataAndIconURLCandidates();
215 214
216 // See description above class for details. 215 // See description above class for details.
217 void OnFaviconDataForInitialURLFromFaviconService(const std::vector< 216 void OnFaviconDataForInitialURLFromFaviconService(const std::vector<
218 favicon_base::FaviconRawBitmapResult>& favicon_bitmap_results); 217 favicon_base::FaviconRawBitmapResult>& favicon_bitmap_results);
219 218
220 // If the favicon currently mapped to |url_| has expired, downloads the 219 // If the favicon currently mapped to |url_| has expired, downloads the
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 // UpdateFaviconCandidate()), the favicon service and the delegate are 361 // UpdateFaviconCandidate()), the favicon service and the delegate are
363 // notified. 362 // notified.
364 DownloadedFavicon best_favicon_; 363 DownloadedFavicon best_favicon_;
365 364
366 DISALLOW_COPY_AND_ASSIGN(FaviconHandler); 365 DISALLOW_COPY_AND_ASSIGN(FaviconHandler);
367 }; 366 };
368 367
369 } // namespace favicon 368 } // namespace favicon
370 369
371 #endif // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_ 370 #endif // COMPONENTS_FAVICON_CORE_FAVICON_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698