Optimize promotion of ephemeral apps

chrome/browser/extensions/webstore_standalone_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_standalone_installer.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/webstore_data_fetcher.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/extension_prefs.h"
+#include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/extension_util.h"
 #include "extensions/common/extension.h"
 #include "url/gurl.h"
 
 using content::WebContents;
 
 namespace extensions {
 
 const char kInvalidWebstoreItemId[] = "Invalid Chrome Web Store item ID";
@@ skipping 198 matching lines @@
     const std::string& error_message) {
   CompleteInstall(error_message);
 }
 
 void WebstoreStandaloneInstaller::InstallUIProceed() {
   if (!CheckRequestorAlive()) {
     CompleteInstall(std::string());
     return;
   }
 
+  scoped_ptr<WebstoreInstaller::Approval> approval = CreateApproval();
+
   ExtensionService* extension_service =
       ExtensionSystem::Get(profile_)->extension_service();
   const Extension* extension =
       extension_service->GetExtensionById(id_, true /* include disabled */);
   if (extension) {
     std::string install_result;  // Empty string for install success.
-    if (!extension_service->IsExtensionEnabled(id_)) {
-      if (!ExtensionPrefs::Get(profile_)->IsExtensionBlacklisted(id_)) {
-        // If the extension is installed but disabled, and not blacklisted,
-        // enable it.
-        extension_service->EnableExtension(id_);
-      } else {  // Don't install a blacklisted extension.
-        install_result = kExtensionIsBlacklisted;
-      }
-    } else if (!util::IsEphemeralApp(extension->id(), profile_)) {
-      // else extension is installed and enabled; no work to be done.
-      CompleteInstall(install_result);
-      return;
-    }
 
-    // TODO(tmdiep): Optimize installation of ephemeral apps. For now we just
-    // reinstall the app.
+    if (ExtensionPrefs::Get(profile_)->IsExtensionBlacklisted(id_)) {
+      // Don't install a blacklisted extension.
+      install_result = kExtensionIsBlacklisted;
+    } else if (util::IsEphemeralApp(extension->id(), profile_) &&
+               !approval->is_ephemeral) {
+      // If the target extension has already been installed ephemerally, it can
+      // be promoted to a regular installed extension and downloading from the
+      // Web Store is not necessary.
+      extension_service->InstallEphemeralApp(extension, true);
+    } else if (!extension_service->IsExtensionEnabled(id_)) {
+      // If the extension is installed but disabled, and not blacklisted,
+      // enable it.
+      extension_service->EnableExtension(id_);
+    }  // else extension is installed and enabled; no work to be done.
+
+    CompleteInstall(install_result);
+    return;
   }
 
-  scoped_ptr<WebstoreInstaller::Approval> approval = CreateApproval();
-
   scoped_refptr<WebstoreInstaller> installer = new WebstoreInstaller(
       profile_,
       this,
       GetWebContents(),
       id_,
       approval.Pass(),
       install_source_);
   installer->Start();
 }
 
@@ skipping 57 matching lines @@
   // Balanced in InstallUIAbort or indirectly in InstallUIProceed via
   // OnExtensionInstallSuccess or OnExtensionInstallFailure.
   AddRef();
 
   install_ui_ = CreateInstallUI();
   install_ui_->ConfirmStandaloneInstall(
       this, localized_extension_for_display_.get(), &icon_, *install_prompt_);
 }
 
 }  // namespace extensions