Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2972523002: Implement JsKernelToElementMap through KernelToElementMapBase (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement JsKernelToElementMap through KernelToElementMapBase - create indexed entities eagerly in JsKernelToElementMap - copy the env and data object - avoid the need for JsCommonElements and JsElementEnvironment BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/410a5b15853ae5912f8b18b9111b8920b96aeb26

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -1412 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 5 chunks +6 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 13 chunks +90 lines, -1264 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 3 chunks +10 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 23 chunks +162 lines, -103 lines 0 comments Download
M pkg/compiler/lib/src/kernel/env.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-03 13:28:40 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2972523002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/2972523002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode87 pkg/compiler/lib/src/kernel/element_map_impl.dart:87: /// List of member data by `IndexedMember.classIndex`. This ...
3 years, 5 months ago (2017-07-05 20:01:27 UTC) #3
Johnni Winther
https://codereview.chromium.org/2972523002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/2972523002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode87 pkg/compiler/lib/src/kernel/element_map_impl.dart:87: /// List of member data by `IndexedMember.classIndex`. This is ...
3 years, 5 months ago (2017-07-06 12:44:02 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-07-06 12:50:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
410a5b15853ae5912f8b18b9111b8920b96aeb26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698