Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2972473002: Run the generator after updates to spec (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+976 lines, -65 lines) Patch
M pkg/analysis_server/doc/api.html View 9 chunks +84 lines, -47 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_constants.dart View 4 chunks +12 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_generated.dart View 7 chunks +672 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/support/integration_test_methods.dart View 3 chunks +105 lines, -18 lines 0 comments Download
M pkg/analysis_server/test/integration/support/protocol_matchers.dart View 5 chunks +69 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java View 2 chunks +28 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/RequestErrorCode.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
The only changes here are to generated files.
3 years, 5 months ago (2017-07-01 22:35:12 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-02 01:00:01 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-07-02 14:49:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0ee29eadf14981544e97bcb33513bf4273da9b49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698