pkg/kernel/lib/binary/ast_from_binary.dart - Issue 2972343002: [kernel] Insert kernel bodies into VM heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/kernel/lib/binary/ast_from_binary.dart

Issue 2972343002: [kernel] Insert kernel bodies into VM heap (Closed)

Patch Set: Review comments Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/kernel/lib/binary/ast_from_binary.dart

diff --git a/pkg/kernel/lib/binary/ast_from_binary.dart b/pkg/kernel/lib/binary/ast_from_binary.dart

index cfd6efc5116622614133eff19f2501882af509b2..336633446a84793fbdaeec611bfb06c7ea46cd79 100644

--- a/pkg/kernel/lib/binary/ast_from_binary.dart

+++ b/pkg/kernel/lib/binary/ast_from_binary.dart

@@ -535,7 +535,6 @@ class BinaryBuilder {

int fileOffset = readOffset();

int fileEndOffset = readOffset();

int flags = readByte();

- readUInt(); // parent class binary offset.

var name = readName();

var fileUri = readUriReference();

var documentationComment = readStringOrNullIfEmpty();

@@ -574,7 +573,6 @@ class BinaryBuilder {

var fileOffset = readOffset();

var fileEndOffset = readOffset();

var flags = readByte();

- readUInt(); // parent class binary offset.

var name = readName();

var documentationComment = readStringOrNullIfEmpty();

var annotations = readAnnotationList(node);

@@ -618,7 +616,6 @@ class BinaryBuilder {

int kindIndex = readByte();

var kind = ProcedureKind.values[kindIndex];

var flags = readByte();

- readUInt(); // parent class binary offset.

var name = readName();

var fileUri = readUriReference();

var documentationComment = readStringOrNullIfEmpty();

« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »