Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 297233009: Automatically wipe data from devices. (Closed)

Created:
6 years, 6 months ago by navabi
Modified:
6 years, 6 months ago
Reviewers:
dnj, tonyg, jbudorick, zty, luqui
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Automatically wipe data from devices. Wiping data from the device for each build will keep the INSTALL_FAILED_INSUFFICIENT_STORAGE error from happening. Sleeping 75 seconds was determined by minimizing how much time was needed to sleep for the provision and wipe to work on a Nexus 4. BUG=335549 R=jbudorick@chromium.org, tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273402

Patch Set 1 #

Patch Set 2 : Rebase to use new device utils code. #

Patch Set 3 : Fix call to WaitUntilFullyBooted. #

Total comments: 2

Patch Set 4 : Fixed nit and increased timeout. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M build/android/provision_devices.py View 1 2 3 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
navabi
The CQ bit was checked by navabi@google.com
6 years, 6 months ago (2014-05-27 22:53:21 UTC) #1
navabi
The CQ bit was unchecked by navabi@google.com
6 years, 6 months ago (2014-05-27 22:53:31 UTC) #2
navabi
This CL is the fix of https://codereview.chromium.org/283363008/ That CL somehow got the .gitmodules messed up ...
6 years, 6 months ago (2014-05-28 20:55:00 UTC) #3
tonyg
lgtm
6 years, 6 months ago (2014-05-28 20:57:32 UTC) #4
jbudorick
lgtm with nit After the refactor lands, we should be able to do provisioning entirely ...
6 years, 6 months ago (2014-05-28 21:18:19 UTC) #5
navabi
https://codereview.chromium.org/297233009/diff/40001/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/297233009/diff/40001/build/android/provision_devices.py#newcode138 build/android/provision_devices.py:138: device.WaitUntilFullyBooted(timeout=75) if you look at the android tests try ...
6 years, 6 months ago (2014-05-28 22:42:59 UTC) #6
navabi
The CQ bit was checked by navabi@google.com
6 years, 6 months ago (2014-05-28 22:44:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/297233009/40002
6 years, 6 months ago (2014-05-28 22:45:20 UTC) #8
navabi
6 years, 6 months ago (2014-05-28 23:42:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as r273402 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698