Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: pkg/kernel/lib/target/flutter_fasta.dart

Issue 2972323002: Add 'flutter_release' patch_sdk mode to patch_sdk (Closed)
Patch Set: Replace flag with dedicated target Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/lib/target/flutter_fasta.dart
diff --git a/pkg/kernel/lib/target/flutter_fasta.dart b/pkg/kernel/lib/target/flutter_fasta.dart
index 2c280d5342cb0cf47d41e20efd505fe4aeeb542c..50cdfd8249f08062064c233b3a8942ef9395f228 100644
--- a/pkg/kernel/lib/target/flutter_fasta.dart
+++ b/pkg/kernel/lib/target/flutter_fasta.dart
@@ -42,3 +42,11 @@ class FlutterFastaTarget extends flutter_target.FlutterTarget {
void performGlobalTransformations(CoreTypes coreTypes, Program program,
{void logger(String msg)}) {}
}
+
+class FlutterFastaReleaseTarget extends FlutterFastaTarget {
+ FlutterFastaReleaseTarget(TargetFlags flags) : super(flags) {
ahe 2017/07/10 13:19:02 super(flags, includeVmService: false);
aam 2017/07/10 22:11:37 I tried doing something like that but got stuck wi
+ // Release target should not have vmservice because it should not have
+ // observatory debugging or profiling functionality available.
+ includeVMService = false;
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698