Add 'flutter_release' patch_sdk mode to patch_sdk

tools/patch_sdk.dart

 #!/usr/bin/env dart
 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Command line tool to merge the SDK libraries and our patch files.
 /// This is currently designed as an offline tool, but we could automate it.
 
 import 'dart:io';
 import 'dart:isolate' show RawReceivePort;
@@ skipping 63 matching lines @@
       path.join(repositoryDir, 'out', 'DebugX64', 'obj', 'gen', 'patch'));
   final outExample = path.relative(
       path.join(repositoryDir, 'out', 'DebugX64', 'obj', 'gen', 'patched_sdk'));
   final packagesExample = path.relative(path.join(repositoryDir, '.packages'));
   print('For example:');
   print('\$ $self vm $sdkExample $patchExample $outExample $packagesExample');
 
   exit(1);
 }
 
-const validModes = const ['vm', 'dart2js', 'flutter'];
+const validModes = const ['vm', 'dart2js', 'flutter', 'flutter_release'];
 String mode;
 bool get forVm => mode == 'vm';
-bool get forFlutter => mode == 'flutter';
+bool get forFlutter => mode == 'flutter' || mode == 'flutter_release';
+bool get forFlutterRelease => mode == 'flutter_release';
 bool get forDart2js => mode == 'dart2js';
 
 Future _main(List<String> argv) async {
   if (argv.isEmpty) usage('[${validModes.join('|')}]');
   mode = argv.first;
   if (!validModes.contains(mode)) usage('[${validModes.join('|')}]');
   if (argv.length != 5) usage(mode);
 
   var input = argv[1];
   var sdkLibIn = path.join(input, 'lib');
@@ skipping 106 matching lines @@
 Future<List<Uri>> compilePlatform(Uri patchedSdk, Target target, Uri packages,
     Uri fullOutput, Uri outlineOutput) async {
   var options = new CompilerOptions()
     ..strongMode = false
     ..compileSdk = true
     ..sdkRoot = patchedSdk
     ..packagesFileUri = packages
     ..chaseDependencies = true
     ..target = target;
 
+  var inputs = [Uri.parse('dart:core')];
+  if (forFlutter && !forFlutterRelease) {
+    inputs.add(Uri.parse('dart:vmservice_sky'));
+  }
   var result = await generateKernel(
       new ProcessedOptions(
           options,
           // TODO(sigmund): pass all sdk libraries needed here, and make this
           // hermetic.
           false,
-          [Uri.parse('dart:core')]),
+          inputs),
       buildSummary: true,
       buildProgram: true);
   new File.fromUri(outlineOutput).writeAsBytesSync(result.summary);
   await writeProgramToFile(result.program, fullOutput);
   return result.deps;
 }
 
 Future writeDepsFile(
     Uri output, Uri depsFile, Iterable<Uri> allDependencies) async {
   if (allDependencies.isEmpty) return;
@@ skipping 54 matching lines @@
 
   if (forFlutter) {
     extraLibraries.write('''
       "ui": const LibraryInfo(
           "ui/ui.dart",
           categories: "Client,Server",
           implementation: true,
           documented: false,
           platforms: VM_PLATFORM),
     ''');
+
+    if (!forFlutterRelease) {
+      // vmservice should be present unless we build release flavor of Flutter.
+      extraLibraries.write('''
+       "_vmservice": const LibraryInfo(
+           "vmservice/vmservice.dart",
+           categories: "Client,Server",
+           implementation: true,
+           documented: false,
+           platforms: VM_PLATFORM),
+
+        "vmservice_sky": const LibraryInfo(
+            "vmservice_sky/vmservice_io.dart",
+            categories: "Client,Server",
+            implementation: true,
+            documented: false,
+            platforms: VM_PLATFORM),
+
+      ''');
+    }
   }
 
   libContents = libContents.replaceAll(
       ' libraries = const {', ' libraries = const { $extraLibraries');
   _writeSync(
       path.join(
           sdkOut, '_internal', 'sdk_library_metadata', 'lib', 'libraries.dart'),
       libContents);
   return libContents;
 }
@@ skipping 18 matching lines @@
     //       flutter/
     var srcDir = path.dirname(path.dirname(path.dirname(path.absolute(base))));
     var uiLibraryInDir = path.join(srcDir, 'flutter', 'lib', 'ui');
     for (var file in new Directory(uiLibraryInDir).listSync()) {
       if (!file.path.endsWith('.dart')) continue;
       var name = path.basename(file.path);
       var uiLibraryOut = path.join(sdkOut, 'ui', name);
       _writeSync(uiLibraryOut, readInputFile(file.path));
     }
     locations['ui'] = 'ui/ui.dart';
+
+    if (!forFlutterRelease) {

[Siggi Cherem (dart-lang), 2017/07/12 18:06:18]

is the intent to eventually get rid of this? I mean, to make the flutter-engine
support loading vmservice from a separate .dill file in the profile/debug cases?

If so - let's add a TODO here about it.

[aam, 2017/07/13 16:30:56]

If I understand correctly, we won't be able to load more than two
dills(platform.dill+script.dill) into vm isolate. So having three
dills(platform.dill+script.dill+vmservice.dill) won't work when we need to load
all of them into vm isolate to produce single aot snapshot with app script and
vmservice in it[which we do for profile build].

+      // vmservice should be present unless we build release flavor of Flutter.
+      for (var file in ['loader.dart', 'server.dart', 'vmservice_io.dart']) {
+        var libraryIn = path.join(dartDir, 'runtime', 'bin', 'vmservice', file);
+        var libraryOut = path.join(sdkOut, 'vmservice_io', file);
+        _writeSync(libraryOut, readInputFile(libraryIn));
+      }
+      locations['vmservice_sky'] =
+          path.join('vmservice_io', 'vmservice_io.dart');
+      locations['_vmservice'] = path.join('vmservice', 'vmservice.dart');
+    }
   }
 }
 
 _applyPatch(SdkLibrary library, String sdkLibIn, String patchIn, String sdkOut,
     Map<String, String> locations) {
   var libraryOut = path.join(sdkLibIn, library.path);
   var libraryIn = libraryOut;
 
   var libraryFile = getInputFile(libraryIn, canBeMissing: true);
   if (libraryFile != null) {
@@ skipping 396 matching lines @@
     if (diff != 0) return diff;
     return end - other.end;
   }
 }
 
 List<SdkLibrary> _getSdkLibraries(String contents) {
   var libraryBuilder = new SdkLibrariesReader_LibraryBuilder(forDart2js);
   parseCompilationUnit(contents).accept(libraryBuilder);
   return libraryBuilder.librariesMap.sdkLibraries;
 }