Issue 2972233002: Don't summarize labels, remove resynthesis code for labels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2972233002: Don't summarize labels, remove resynthesis code for labels. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't summarize labels, remove resynthesis code for labels. This removes UnlinkedLabel altogether, because it is not used anywhere else. We need to keep the corresponding field, so I changed its type to String. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a092694280299cea34f1db204cf9a258baad9c76

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -373 lines)			Patch
M	pkg/analyzer/lib/src/dart/analysis/driver.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/dart/element/element.dart	View	4 chunks	+2 lines, -57 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/format.dart	View	13 chunks	+4 lines, -203 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/format.fbs	View	Binary file		0 comments	Download
M	pkg/analyzer/lib/src/summary/idl.dart	View	2 chunks	+2 lines, -32 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summarize_ast.dart	View	4 chunks	+0 lines, -23 lines	0 comments	Download
M	pkg/analyzer/test/src/summary/summary_common.dart	View	1 chunk	+0 lines, -57 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 5 months ago (2017-07-07 17:22:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a092694280299cea34f1db204cf9a258baad9c76 (presubmit successful).