Issue 297223005: Add a move constructor and move assignment operator to KURL

Issue 297223005: Add a move constructor and move assignment operator to KURL (Closed)

Created:
6 years, 7 months ago by Inactive

Modified:
6 years, 7 months ago

Reviewers:
tkent, Nico

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add a move constructor and move assignment operator to KURL Add a move constructor and move assignment operator to KURL for performance. I loaded gmail.com and the new constructor / assignment operator were called ~1500 times. R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174829

Patch Set 1 #

Patch Set 2 : Stop using std::move #

Total comments: 4

Patch Set 3 : Add FIXME comment #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
	M	Source/platform/weborigin/KURL.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	Source/platform/weborigin/KURL.cpp	View	1 2	1 chunk	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

lgtm https://codereview.chromium.org/297223005/diff/10001/Source/platform/weborigin/KURL.cpp File Source/platform/weborigin/KURL.cpp (right): https://codereview.chromium.org/297223005/diff/10001/Source/platform/weborigin/KURL.cpp#newcode263 Source/platform/weborigin/KURL.cpp:263: , m_string(static_cast<String&&>(other.m_string)) Would you add FIXME about std::move ...

6 years, 7 months ago (2014-05-27 00:19:16 UTC) #2

Inactive

https://codereview.chromium.org/297223005/diff/10001/Source/platform/weborigin/KURL.cpp File Source/platform/weborigin/KURL.cpp (right): https://codereview.chromium.org/297223005/diff/10001/Source/platform/weborigin/KURL.cpp#newcode263 Source/platform/weborigin/KURL.cpp:263: , m_string(static_cast<String&&>(other.m_string)) On 2014/05/27 00:19:16, tkent wrote: > Would ...

6 years, 7 months ago (2014-05-27 00:30:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/297223005/30001

6 years, 7 months ago (2014-05-27 00:30:24 UTC) #5

Message was sent while issue was closed.

Change committed as 174829

Expand Messages | Collapse Messages