third_party/WebKit/Source/build/scripts/make_css_value_keywords.py - Issue 2972193002: Use unique variable names in gperf generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_css_value_keywords.py

Issue 2972193002: Use unique variable names in gperf generated code (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/build/scripts/make_css_value_keywords.py

diff --git a/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py b/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py

index f8b773c8971473ec04c5c7c3786fda5aec68e8ec..608ffd5e97f02bfc1003fb534243b8aa07f30950 100755

--- a/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py

+++ b/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py

@@ -174,6 +174,7 @@ class CSSValueKeywordsWriter(json5_generator.Writer):

gperf_args = [self.gperf_path, '--key-positions=*', '-P', '-n']

gperf_args.extend(['-m', '50']) # Pick best of 50 attempts.

gperf_args.append('-D') # Allow duplicate hashes -> More compact code.

+ gperf_args.extend(['-Q', 'ValueStringPool']) # Unique var names.

fs 2017/07/07 12:58:30 Maybe CSSValueStringPool?

Daniel Bratell 2017/07/07 13:20:50 Done.

# If gperf isn't in the path we get an OSError. We don't want to use

# the normal solution of shell=True (as this has to run on many

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_css_property_names.py ('k') | no next file » | no next file with comments »