Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 297213006: Reland 21529 - "Add a flag to d8 to invoke weak callbacks" (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Reland 21529 - "Add a flag to d8 to invoke weak callbacks" > This will send an idle notification and a low memory notification after > each test. > > For some reason it's not enough to send a low memory notification alone. > > BUG=none > R=yangguo@chromium.org > LOG=n BUG=none R=yangguo@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M src/d8.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/d8.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M tools/run-tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-27 15:06:38 UTC) #1
Yang
On 2014/05/27 15:06:38, jochen wrote: lgtm.
6 years, 7 months ago (2014-05-27 15:12:51 UTC) #2
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-27 15:16:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21536 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698