chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc - Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked. (Closed)

Patch Set: Grammar Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h ('k') | chrome/browser/plugins/plugin_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

index 7bdcea59c44544c978530c82be68bcd18bd33669..bcb040bdd8755c4aae2c8d82e0870da16834f04b 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

@@ -62,6 +62,7 @@ bool ChromeWebViewPermissionHelperDelegate::OnMessageReceived(

OnCouldNotLoadPlugin)

IPC_MESSAGE_HANDLER(ChromeViewHostMsg_RemovePluginPlaceholderHost,

OnRemovePluginPlaceholderHost)

+ IPC_MESSAGE_HANDLER(ChromeViewHostMsg_OpenPDF, OnOpenPDF)

IPC_MESSAGE_UNHANDLED(return false)

IPC_END_MESSAGE_MAP()

@@ -113,6 +114,10 @@ void ChromeWebViewPermissionHelperDelegate::OnPermissionResponse(

#endif // BUILDFLAG(ENABLE_PLUGINS)

+void ChromeWebViewPermissionHelperDelegate::OnOpenPDF(const GURL& url) {

+ // Intentionally blank since guest views should never trigger PDF downloads.

void ChromeWebViewPermissionHelperDelegate::CanDownload(

const GURL& url,

const std::string& request_method,