chrome/common/render_messages.h - Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/render_messages.h

Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked. (Closed)

Patch Set: . Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, no traditional include guard.	5 // Multiply-included file, no traditional include guard.

6 #include <stdint.h>	6 #include <stdint.h>

7 #include <string>	7 #include <string>

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/files/file_path.h"	10 #include "base/files/file_path.h"

(...skipping 323 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
334 // process so that they can be assigned to an Instant renderer.	334 // process so that they can be assigned to an Instant renderer.

335 IPC_MESSAGE_CONTROL2(ChromeViewMsg_SetSearchURLs,	335 IPC_MESSAGE_CONTROL2(ChromeViewMsg_SetSearchURLs,

336 std::vector<GURL> /* search_urls */,	336 std::vector<GURL> /* search_urls */,

337 GURL /* new_tab_page_url */)	337 GURL /* new_tab_page_url */)

338	338

339 #if BUILDFLAG(ENABLE_PLUGINS)	339 #if BUILDFLAG(ENABLE_PLUGINS)

340 // Sent by the renderer to check if crash reporting is enabled.	340 // Sent by the renderer to check if crash reporting is enabled.

341 IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled,	341 IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled,

342 bool /* enabled */)	342 bool /* enabled */)

343 #endif	343 #endif

	344

	345 // Tells the browser to open a PDF file in a new tab. Used when plugins are
	Lei Zhang 2017/07/07 21:27:52 OK, so now this says to open a PDF in a new tab, b OK, so now this says to open a PDF in a new tab, but the message name says "DownloadPDF" and the CL description says "Download PDF". It's unclear what the actual goal is. Maybe clarifying this will also help decide whether to use OpenURL() or SaveFrame(). amberwon 2017/07/07 21:52:22 Done. Chose to go with opening the PDF instead of Show quoted text On 2017/07/07 21:27:52, Lei Zhang wrote: > OK, so now this says to open a PDF in a new tab, but the message name says > "DownloadPDF" and the CL description says "Download PDF". It's unclear what the > actual goal is. Maybe clarifying this will also help decide whether to use > OpenURL() or SaveFrame(). Done. Chose to go with opening the PDF instead of downloading it.
	346 // disabled and user clicks to view PDF.

	347 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_DownloadPDF, GURL /* url */)

OLD	NEW

« no previous file with comments | « chrome/browser/plugins/plugin_observer.cc ('k') | chrome/renderer/plugins/pdf_plugin_placeholder.cc » ('j') | no next file with comments »