chrome/common/render_messages.h - Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked.

Side by Side Diff: chrome/common/render_messages.h

Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked. (Closed)

Patch Set: remove id since it's not used Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/browser/plugins/plugin_observer.cc ('K') | « chrome/browser/plugins/plugin_observer.cc ('k') | chrome/renderer/plugins/pdf_plugin_placeholder.cc » ('j') | chrome/renderer/plugins/pdf_plugin_placeholder.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, no traditional include guard.	5 // Multiply-included file, no traditional include guard.

6 #include <stdint.h>	6 #include <stdint.h>

7 #include <string>	7 #include <string>

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/files/file_path.h"	10 #include "base/files/file_path.h"

(...skipping 323 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
334 // process so that they can be assigned to an Instant renderer.	334 // process so that they can be assigned to an Instant renderer.

335 IPC_MESSAGE_CONTROL2(ChromeViewMsg_SetSearchURLs,	335 IPC_MESSAGE_CONTROL2(ChromeViewMsg_SetSearchURLs,

336 std::vector<GURL> /* search_urls */,	336 std::vector<GURL> /* search_urls */,

337 GURL /* new_tab_page_url */)	337 GURL /* new_tab_page_url */)

338	338

339 #if BUILDFLAG(ENABLE_PLUGINS)	339 #if BUILDFLAG(ENABLE_PLUGINS)

340 // Sent by the renderer to check if crash reporting is enabled.	340 // Sent by the renderer to check if crash reporting is enabled.

341 IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled,	341 IPC_SYNC_MESSAGE_CONTROL0_1(ChromeViewHostMsg_IsCrashReportingEnabled,

342 bool /* enabled */)	342 bool /* enabled */)

343 #endif	343 #endif

	344

	345 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_DownloadPDF, GURL /* url */)
	Lei Zhang 2017/07/07 17:45:45 Can you explain what this does? Can you explain what this does? Lei Zhang 2017/07/07 17:45:45 Does this belong inside the #if BUILDFLAG(ENABLE_P Does this belong inside the #if BUILDFLAG(ENABLE_PLUGINS) section? tommycli 2017/07/07 17:55:10 For this particular one -- no - since Android need Show quoted text On 2017/07/07 17:45:45, Lei Zhang wrote: > Does this belong inside the #if BUILDFLAG(ENABLE_PLUGINS) section? For this particular one -- no - since Android needs this as well. Which brings up another point -- we may need to move this to a different class (other than PluginObserver) if that's not created on Android. For now I'm okay with deferring making it work on !ENABLE_PLUGINS until a followup. amberwon 2017/07/07 20:44:22 This declares the message (ChromeViewHostMsg_Downl Show quoted text On 2017/07/07 17:45:45, Lei Zhang wrote: > Can you explain what this does? This declares the message (ChromeViewHostMsg_DownloadPDF), with a GURL as an argument. Lei Zhang 2017/07/07 21:08:20 Can you describe what it does, as a comment in the Show quoted text On 2017/07/07 20:44:22, amberwon wrote: > On 2017/07/07 17:45:45, Lei Zhang wrote: > > Can you explain what this does? > > This declares the message (ChromeViewHostMsg_DownloadPDF), with a > GURL as an argument. Can you describe what it does, as a comment in the code? Like all the existing IPC messages above it. amberwon 2017/07/07 21:23:09 Done. Show quoted text On 2017/07/07 21:08:20, Lei Zhang wrote: > On 2017/07/07 20:44:22, amberwon wrote: > > On 2017/07/07 17:45:45, Lei Zhang wrote: > > > Can you explain what this does? > > > > This declares the message (ChromeViewHostMsg_DownloadPDF), with a > > GURL as an argument. > > Can you describe what it does, as a comment in the code? Like all the existing > IPC messages above it. Done.
OLD	NEW