Click to Open PDF: Open PDF once View PDF is clicked.

chrome/browser/plugins/plugin_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugins/plugin_observer.h"
 
 #include <utility>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
@@ skipping 249 matching lines @@
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_BlockedOutdatedPlugin,
                         OnBlockedOutdatedPlugin)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_BlockedComponentUpdatedPlugin,
                         OnBlockedComponentUpdatedPlugin)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_RemovePluginPlaceholderHost,
                         OnRemovePluginPlaceholderHost)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_ShowFlashPermissionBubble,
                         OnShowFlashPermissionBubble)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_CouldNotLoadPlugin,
                         OnCouldNotLoadPlugin)
+    IPC_MESSAGE_HANDLER(ChromeViewHostMsg_DownloadPDF, OnDownloadPDF)
 
     IPC_MESSAGE_UNHANDLED(return false)
   IPC_END_MESSAGE_MAP()
 
   return true;
 }
 
 void PluginObserver::OnBlockedOutdatedPlugin(int placeholder_id,
                                              const std::string& identifier) {
   PluginFinder* finder = PluginFinder::GetInstance();
@@ skipping 48 matching lines @@
       plugin_path);
   base::string16 plugin_name =
       PluginService::GetInstance()->GetPluginDisplayNameByPath(plugin_path);
   SimpleAlertInfoBarDelegate::Create(
       InfoBarService::FromWebContents(web_contents()),
       infobars::InfoBarDelegate::PLUGIN_OBSERVER, &kExtensionCrashedIcon,
       l10n_util::GetStringFUTF16(IDS_PLUGIN_INITIALIZATION_ERROR_PROMPT,
                                  plugin_name),
       true);
 }
+
+void PluginObserver::OnDownloadPDF(const GURL& url) {
+  web_contents()->OpenURL(content::OpenURLParams(

[Lei Zhang, 2017/07/07 17:45:45]

Have you looked into OpenURL() vs SaveFrame() ?

[amberwon, 2017/07/07 20:44:22]

I've looked into both. At the moment, both Tommy and I aren't sure
which one would be more appropriate to use. For now, I'll stick with
OpenURL and if we find that SaveFrame would be better, we can change
it then.

[Lei Zhang, 2017/07/07 21:08:20]

FWIW, SaveFrame() is used exclusively by the PDF plugin, and it has much few
parameters. Internally it just calls SaveFrameWithHeaders() which has a few more
callers. SaveFrameWithHeaders() then goes straight to download code, whereas
it's not clear what OpenURL() will do.

+      url,
+      content::Referrer::SanitizeForRequest(
+          url, content::Referrer(web_contents()->GetURL(),
+                                 blink::kWebReferrerPolicyDefault)),
+      WindowOpenDisposition::NEW_FOREGROUND_TAB,
+      ui::PAGE_TRANSITION_AUTO_BOOKMARK, false));
+}