chrome/renderer/plugins/pdf_plugin_placeholder.h - Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/plugins/pdf_plugin_placeholder.h

Issue 2972123002: Click to Open PDF: Open PDF once View PDF is clicked. (Closed)

Patch Set: Grammar Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/render_messages.h ('k') | chrome/renderer/plugins/pdf_plugin_placeholder.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_	5 #ifndef CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_

6 #define CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_	6 #define CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_

7	7

8 #include "components/plugins/renderer/plugin_placeholder.h"	8 #include "components/plugins/renderer/plugin_placeholder.h"

9	9

10 // Placeholder that allows users to click to download a PDF for when	10 // Placeholder that allows users to click to download a PDF for when

(...skipping 16 matching lines...) Expand all Loading...
27 const blink::WebPluginParams& params,	27 const blink::WebPluginParams& params,

28 const std::string& html_data);	28 const std::string& html_data);

29 ~PDFPluginPlaceholder() final;	29 ~PDFPluginPlaceholder() final;

30	30

31 // WebViewPlugin::Delegate methods:	31 // WebViewPlugin::Delegate methods:

32 v8::Local<v8::Value> GetV8Handle(v8::Isolate* isolate) final;	32 v8::Local<v8::Value> GetV8Handle(v8::Isolate* isolate) final;

33	33

34 gin::ObjectTemplateBuilder GetObjectTemplateBuilder(	34 gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

35 v8::Isolate* isolate) final;	35 v8::Isolate* isolate) final;

36	36

37 void DownloadPDFCallback();	37 void OpenPDFCallback();

38 };	38 };

39	39

40 #endif // CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_	40 #endif // CHROME_RENDERER_PLUGINS_PDF_PLUGIN_PLACEHOLDER_H_

OLD	NEW