Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2972093002: Remove code for computing summaries based on the Fasta parser. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove code for computing summaries based on the Fasta parser. This code was never completed, and since then we've decided to do something different: summaries for the new front end will be based on kernel format rather than analyzer summary format. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/9a669557d7642fe950b5ebfa7e181e430ba9905b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2926 lines) Patch
D pkg/analyzer/lib/src/summary/fasta/expression_serializer.dart View 1 chunk +0 lines, -262 lines 0 comments Download
D pkg/analyzer/lib/src/summary/fasta/expressions.dart View 1 chunk +0 lines, -308 lines 0 comments Download
D pkg/analyzer/lib/src/summary/fasta/model.dart View 1 chunk +0 lines, -190 lines 0 comments Download
D pkg/analyzer/lib/src/summary/fasta/stack_listener.dart View 1 chunk +0 lines, -140 lines 0 comments Download
D pkg/analyzer/lib/src/summary/fasta/summary_builder.dart View 1 chunk +0 lines, -1568 lines 0 comments Download
D pkg/analyzer/lib/src/summary/fasta/visitor.dart View 1 chunk +0 lines, -141 lines 0 comments Download
D pkg/analyzer/test/src/summary/summarize_fasta_test.dart View 1 chunk +0 lines, -317 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
I only need a review from one of you. Including Siggi mostly as FYI, since ...
3 years, 5 months ago (2017-07-06 20:39:59 UTC) #2
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-07-06 20:41:17 UTC) #3
Paul Berry
3 years, 5 months ago (2017-07-06 20:43:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a669557d7642fe950b5ebfa7e181e430ba9905b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698