Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(6)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/fast/loader/stateobjects/spam-pushstate-then-throttled-expected.txt
Issue
2972073002
:
Mitigate the pushState IPC storm DoS. (Closed)
Patch Set: Add a LayoutTest; give the bikeshed a bit o' wainscoting
Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/fast/loader/stateobjects/spam-pushstate-then-throttled.html
third_party/WebKit/LayoutTests/fast/loader/stateobjects/spam-pushstate-then-throttled-expected.txt
third_party/WebKit/Source/core/frame/History.h
third_party/WebKit/Source/core/frame/History.cpp
View unified diff
|
Download patch
« third_party/WebKit/LayoutTests/fast/loader/stateobjects/spam-pushstate-then-throttled.html
('K') |
« third_party/WebKit/LayoutTests/fast/loader/stateobjects/spam-pushstate-then-throttled.html
('k') |
third_party/WebKit/Source/core/frame/History.h »
('j') |
third_party/WebKit/Source/core/frame/History.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
This test does the following:
2
-Makes kStateUpdateLimit calls to pushState()
3
-Makes sure the history length is correct
4
-Makes another call to pushState()
5
-Makes sure the history length is correct
6
-Goes back, and makes sure the popstate event is correct
7
8
History length is 50
9
History length is 50
10
State popped - SpammyHistoryItem (type string)
11
OLD
NEW
« third_party/WebKit/LayoutTests/fast/loader/stateobjects/spam-pushstate-then-throttled.html
('K') |
« third_party/WebKit/LayoutTests/fast/loader/stateobjects/spam-pushstate-then-throttled.html
('k') |
third_party/WebKit/Source/core/frame/History.h »
('j') |
third_party/WebKit/Source/core/frame/History.cpp »
('J')
Issue 2972073002: Mitigate the pushState IPC storm DoS. (Closed)
Created 3 years, 5 months ago by palmer
Modified 3 years, 5 months ago
Reviewers: Charlie Reis, dcheng, kinuko, Ćukasz Anforowicz
Base URL:
Comments: 22
This is Rietveld
408576698