Mitigate the pushState IPC storm DoS.

third_party/WebKit/Source/core/frame/History.cpp

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 98 matching lines @@
 }
 
 HistoryScrollRestorationType History::ScrollRestorationInternal() const {
   HistoryItem* history_item =
       GetFrame() ? GetFrame()->Loader().GetDocumentLoader()->GetHistoryItem()
                  : nullptr;
   return history_item ? history_item->ScrollRestorationType()
                       : kScrollRestorationAuto;
 }
 
+// TODO(crbug.com/394296): This is not the long-term fix to IPC flooding that we
+// need. However, it does somewhat mitigate the immediate concern of |pushState|
+// and |replaceState| DoS (assuming the renderer has not been compromised).
+bool History::IsFloodingState(const String& hostname) const {

[Łukasz Anforowicz, 2017/07/07 21:05:17]

|hostname| parameter is unused now and can be removed, right?

[palmer, 2017/07/07 21:38:17]

Done.

+  const int kStateUpdateLimit = 50;
+
+  if (state_flood_guard.count > kStateUpdateLimit) {
+    constexpr auto kStateUpdateLimitResetInterval = TimeDelta::FromSeconds(10);

[dcheng, 2017/07/07 21:04:09]

Nit: static

[palmer, 2017/07/07 21:38:17]

Done.

+    const auto now = TimeTicks::Now();
+    if (now - state_flood_guard.last_updated > kStateUpdateLimitResetInterval) {
+      state_flood_guard.count = 0;
+      state_flood_guard.last_updated = now;

[dcheng, 2017/07/07 21:04:09]

Do we want to allow in this case, since > 10 seconds has elapsed?

[Łukasz Anforowicz, 2017/07/07 21:05:17]

TL;DR: Do you need a |return false| statement above?

What happens if a well-behaved page pushes state changes every 10 seconds.  We
don't want to loose any user data in this case, right?  If I understand the code
correctly, then in this the legitimate/slow 50-th push would get here and would
be classified as flooding and dropped - this seems undesirable.

[palmer, 2017/07/07 21:38:17]

Yep, done.

+    }
+    return true;
+  }
+
+  state_flood_guard.count++;
+  return false;
+}
+
 bool History::stateChanged() const {
   return last_state_object_requested_ != StateInternal();
 }
 
 bool History::IsSameAsCurrentState(SerializedScriptValue* state) const {
   return state == StateInternal();
 }
 
 void History::back(ScriptState* script_state) {
   go(script_state, -1);
@@ skipping 80 matching lines @@
 void History::StateObjectAdded(PassRefPtr<SerializedScriptValue> data,
                                const String& /* title */,
                                const String& url_string,
                                HistoryScrollRestorationType restoration_type,
                                FrameLoadType type,
                                ExceptionState& exception_state) {
   if (!GetFrame() || !GetFrame()->GetPage() ||
       !GetFrame()->Loader().GetDocumentLoader())
     return;
 
+  if (IsFloodingState(GetFrame()->GetDocument()->GetSecurityOrigin()->Host())) {
+    return;
+  }
+
   KURL full_url = UrlForState(url_string);
   if (!CanChangeToUrl(full_url, GetFrame()->GetDocument()->GetSecurityOrigin(),
                       GetFrame()->GetDocument()->Url())) {
     // We can safely expose the URL to JavaScript, as a) no redirection takes
     // place: JavaScript already had this URL, b) JavaScript can only access a
     // same-origin History object.
     exception_state.ThrowSecurityError(
         "A history state object with URL '" + full_url.ElidedString() +
         "' cannot be created in a document with origin '" +
         GetFrame()->GetDocument()->GetSecurityOrigin()->ToString() +
         "' and URL '" + GetFrame()->GetDocument()->Url().ElidedString() + "'.");
     return;
   }
 
   GetFrame()->Loader().UpdateForSameDocumentNavigation(
       full_url, kSameDocumentNavigationHistoryApi, std::move(data),
       restoration_type, type, GetFrame()->GetDocument());
 }
 
 }  // namespace blink